@defstat, could you have a look at this one, both the PR for stable-3_4_0 and to check whether this needs attention in stable-3_5_0 and main, where it'll be relying instead on the invitation toolset?

Getting failed tests but with errors that seem unrelated.

Any information about this? Thinking mainly whether the changes in overall seem good since I would like to have this in our production site.

@defstat, could you have a look at this one, both the PR for stable-3_4_0 and to check whether this needs attention in stable-3_5_0 and main, where it'll be relying instead on the invitation toolset?

@asmecher @ajnyga sorry for the delay on this.

This does not need porting to stable-3_5_0 and main branches, in my opinion - the one-click feature is handled by invitations after 3.5.0, and the respective code is already in the public function authorize($request, &$args, $roleAssignments) function of the ReviewerHandler class.

Thanks! Agreed that no porting needed, it was rewritten and also OMP had the same logic in 3.5+.
@asmecher I restarted the tests, not sure what caused them to fail the last time since I do not think one-click is used in the tests.

The requested OJS pr here pkp/ojs#5596

Thanks, @ajnyga!

@Tribunal33, this is merged to stable-3_4_0 (and only that branch!) and ready for QA.

@asmecher wild didn't know you could add a PR to my QA project. Anyways this passes -- Tested on OMP 3.4. Do we want to create a formal ticket to capture this? I tried both with this selected and not selected. Enabled, it jumps right to the review and disabled it goes to login page. Looks like the email stays the same regardless of the setting so to have the key associated with the email you will need to have the setting enabled first. The email will not allow for one time click when the email contains a link before setting was enabled.

Tests.

1. Test that the One click reviewer setting is enabled.
2. Add a reviewer
3. Use link with incognito to jump right to review

1. Test that the One click reviewer setting is disabled and email already has one-click key
2. Use link with incognito should redirect to login page

1. Test that the One click reviewer setting is disabled
2. Add a reviewer
3. Use the link with incognito it should redirect to login page.
4. Now turn the One click reviewer setting to Enabled
5. Use the email link again from the same user
6. Should still redirect to login page becuase there is no one-click key in the URL link.